Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add ignoreWhitespace option to isNodeEmpty #5446

Merged
merged 1 commit into from
Aug 6, 2024
Merged

feat(core): add ignoreWhitespace option to isNodeEmpty #5446

merged 1 commit into from
Aug 6, 2024
+86 −25

Conversation

nperez0111
Copy link
Contributor

Changes Overview

Adds a new option to isNodeEmpty to check ignore whitespace present in the node when checking for emptiness.

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2024

🦋 Changeset detected

Latest commit: 4bf1e34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/core Major
@tiptap/extension-blockquote Major
@tiptap/extension-bold Major
@tiptap/extension-bubble-menu Major
@tiptap/extension-bullet-list Major
@tiptap/extension-character-count Major
@tiptap/extension-code-block-lowlight Major
@tiptap/extension-code-block Major
@tiptap/extension-code Major
@tiptap/extension-collaboration-cursor Major
@tiptap/extension-collaboration Major
@tiptap/extension-color Major
@tiptap/extension-document Major
@tiptap/extension-dropcursor Major
@tiptap/extension-floating-menu Major
@tiptap/extension-focus Major
@tiptap/extension-font-family Major
@tiptap/extension-gapcursor Major
@tiptap/extension-hard-break Major
@tiptap/extension-heading Major
@tiptap/extension-highlight Major
@tiptap/extension-history Major
@tiptap/extension-horizontal-rule Major
@tiptap/extension-image Major
@tiptap/extension-italic Major
@tiptap/extension-link Major
@tiptap/extension-list-item Major
@tiptap/extension-list-keymap Major
@tiptap/extension-mention Major
@tiptap/extension-ordered-list Major
@tiptap/extension-paragraph Major
@tiptap/extension-placeholder Major
@tiptap/extension-strike Major
@tiptap/extension-subscript Major
@tiptap/extension-superscript Major
@tiptap/extension-table-cell Major
@tiptap/extension-table-header Major
@tiptap/extension-table-row Major
@tiptap/extension-table Major
@tiptap/extension-task-item Major
@tiptap/extension-task-list Major
@tiptap/extension-text-align Major
@tiptap/extension-text-style Major
@tiptap/extension-text Major
@tiptap/extension-typography Major
@tiptap/extension-underline Major
@tiptap/extension-youtube Major
@tiptap/html Major
@tiptap/react Major
@tiptap/suggestion Major
@tiptap/vue-2 Major
@tiptap/vue-3 Major
@tiptap/starter-kit Major
@tiptap/pm Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 4bf1e34
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66b0f75f0bacf00008539fa9
😎 Deploy Preview https://deploy-preview-5446--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bdbch
bdbch approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdbch bdbch merged commit ae0254d into develop Aug 6, 2024
14 checks passed
@bdbch bdbch deleted the whitespace branch August 6, 2024 08:05
@nperez0111 nperez0111 mentioned this pull request Aug 6, 2024
Merged
5 tasks
nperez0111 added a commit that referenced this pull request Aug 6, 2024
@nperez0111
feat(core): add ignoreWhitespace option to isNodeEmpty (#5446)
f850a2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdbch bdbch bdbch approved these changes

@svenadlung svenadlung Awaiting requested review from svenadlung svenadlung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Tiptap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nperez0111 @bdbch